Conversation
canaandavis
left a comment
canaandavis
left a comment
There was a problem hiding this comment.
Overall, this is looking pretty good.
There are some components missing propTypes, but thats not the end of the world.
Also, I like that you are persisting favorites. Though, the design here could maybe be done in a more efficient way, we'll talk more about those concepts when we look at our backend apis.
Overall great work!!
| ) | ||
| } | ||
|
|
||
| export default Activity; |
There was a problem hiding this comment.
Would like to see the use of propTypes here
src/App.js
Outdated
| axios.get('http://localhost:4000/contacts') | ||
| .then(resp => { | ||
| this.setState({ | ||
| searchText: this.state.searchText, |
There was a problem hiding this comment.
Setting searchText here isn't necessary.
src/App.js
Outdated
| .catch(err => { | ||
| console.log(`Error! ${err}`) | ||
| }) | ||
| axios.get('http://localhost:4000/favorites') |
There was a problem hiding this comment.
I like that you added the ability to have favorites persisted
| } | ||
| } | ||
|
|
||
| export default Contact; |
There was a problem hiding this comment.
Would like to see propTypes here also.
| ); | ||
| } | ||
|
|
||
| export default ContactList; |
There was a problem hiding this comment.
Would like to see propTypes here also.
2 participants
No description provided.