Skip to content

Conversation

@Zitzeronion
Copy link

The two authors Qisu Zou and Xiaoyi He derived this boundary condition, which is shown in their paper: https://pubs.aip.org/aip/pof/article/9/6/1591/260464/On-pressure-and-velocity-boundary-conditions-for

Contributing Guidelines

Description

Just changed the boundary condition name, such that it is clear that it is named after two authors.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Ruff passes

Zitzeronion and others added 2 commits June 25, 2025 13:15
The two authors Qisu Zou and Xiaoyi He derived this boundary condition, which is shown in their paper: https://pubs.aip.org/aip/pof/article/9/6/1591/260464/On-pressure-and-velocity-boundary-conditions-for
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Zitzeronion
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@mehdiataei
Copy link
Contributor

Thanks for the PR. In this codebase and in other LBM software such as OpenLB the existing term is already widely used, which helps with searchability and consistency across tools. To keep that consistency we prefer to retain the current name, so I will close this PR, but I appreciate you taking the time to contribute.

@mehdiataei mehdiataei closed this Nov 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants