Skip to content

Add custom translation ui #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonwheatley wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add custom translation ui #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
864036e
Custom meta field translation UI: Allow the `Babble_Meta_Field` objec…
simonwheatley Aug 20, 2015
79dee30
Custom meta field translation UI: If the value is not a string, then …
simonwheatley Aug 20, 2015
d64baf2
Custom meta field translation UI: If we want to output structured HTM…
simonwheatley Aug 20, 2015
01b72dd
Custom meta field translation UI: Need to set the $value variable bef…
simonwheatley Aug 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion class-jobs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,17 @@ public function save_job( $job_id, WP_Post $job ) {

foreach ( $objects['meta'] as $meta_key => $meta_field ) {

$value = wp_kses_post( $meta_data[ $meta_key ] );
$value = $meta_data[ $meta_key ];

$value = $meta_field->update( $value, $job );

// If the Babble_Meta_Field object update mathod as returned
// something that is not a string, it will break if we apply
// wp_kses to it
// @TODO: Perhaps there's some kind of wp_kses_deep we can use? Would that cause issues with some field/data types?
if ( is_string( $value ) ) {
$value = wp_kses_post( $value );
}

update_post_meta( $job->ID, "bbl_meta_{$meta_key}", $value );

Expand Down
2 changes: 1 addition & 1 deletion templates-admin/translation-editor-meta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<?php echo $original->get_input( "bbl_translation[meta][{$key}]", $translation ); ?>
</div>
<div class="bbl-translation-original bbl-translation-original-meta_key">
<?php echo esc_html( $original->get_output() ); ?>
<?php echo wp_kses_post( $original->get_output() ); ?>
</div>

</div>
Expand Down