This repository was archived by the owner on Nov 6, 2019. It is now read-only.
Camptix Stripe bug-fix (.unique() vs .uniqueSort())#232
Open
EliW wants to merge 1 commit intoAutomattic:masterfrom
Open
Camptix Stripe bug-fix (.unique() vs .uniqueSort())#232EliW wants to merge 1 commit intoAutomattic:masterfrom
EliW wants to merge 1 commit intoAutomattic:masterfrom
Conversation
… in jQuery 3.x which many themes and baseWP don't use. Changing this to just .unique() which is aliased in 3.x and works in 2.x as well for greater compatibility.
Contributor
Author
|
ping ... Just realizing that it's been months and this hasn't been pulled in. Seems like a pretty important fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a PR I'd submitted to the original stripe plugin, but never got accepted there before the code was merged here into the main camptix:
The Stripe plugin uses jQuery.uniqueSort(), however, that function only exists in jQuery 3.x which many themes and even WordPress itself doesn't use or include. Changing this to just .unique() which is aliased in 3.x and works in 2.x as well for greater compatibility. Otherwise lots of people will end up getting failures when trying to use Stripe.