Fix -- PHP Warning: Attempt to read property "post_type" on string i… #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cut a new release from develop
… .../custom-status.php on line 1476 Not sure when this is emitted, but sometimes I see this warning and it is flooding the logs. Probably the problem is somewhere else, or is not a problem at all, but this should mute this warning: ``` PHP Warning: Attempt to read property "post_type" on string in .../edit-flow/modules/custom-status/custom-status.php on line 1476 ```
GaryJones
added a commit
that referenced
this pull request
Dec 12, 2025
The `fix_preview_link_part_two()` filter callback could receive a string URL instead of a WP_Post object when `get_post()` returns null, causing a PHP warning when attempting to access the `post_type` property. This guard clause ensures the parameter is a valid post object before proceeding with any property access. Uses `instanceof WP_Post` for stricter type checking rather than `is_object()`, which would incorrectly accept any object type. Fixes indentation to match surrounding code standards (tabs instead of spaces). Based on PR #747 by @dev4starter, rebased onto develop with improvements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
Contributor
|
Thank you for this fix, @dev4starter! 🙏 I've incorporated your fix into #834 with a couple of improvements:
Your contribution is credited in the commit message and PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not sure when this is emitted, but sometimes I see this warning and it is flooding the logs. Probably the problem is somewhere else, or is not a problem at all, but this should mute this warning: