-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: use a dropdown selector to list eligible users for notifications #45634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
Can you add screenshots to the PR as well? Thanks! |
7e30fe0 to
4e9918f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall works, but this "can't remove last" is a bit clunky:
Screen.Recording.2025-10-29.at.15.13.05.mov
Not sure what should we do about it tho. Allow leave input empty, effectively disabling the feature?
I have mixed feelings about this one too. It's either disable the feature if we leave it empty or default add the post author. I'd suggest merging this and sleeping on it in case we want to change it. |
|
Yep not a blocker for merging — can you pass it by Ilona in case she can solve it? |
To make it easier to select users in the form notification settings, I'm using the FormTokenField dropdown selector variation, which will list all the eligible users we can send notifications to.
4e9918f to
2702f7d
Compare



Fixes FORMS-351
To make it easier to select users in the form notification settings, I'm using the FormTokenField dropdown selector variation, which will list all the eligible users we can send notifications to.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
jetpack_forms_enable_notifications.Enable notifications for responsesin the forms block sidebar Form notifications panel setting.Send notifications toand confirm that a list of users is displayed.