-
Notifications
You must be signed in to change notification settings - Fork 841
Forms: fix integrations modal flash #45775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
CGastrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
Proposed changes:
On the forms dashboard, we recently removed the Integration tab and added an Integrations button that opens a modal. I noticed there's a flash when closing the modal. See video below. I think this is related to making the modal dependent on react routing. This PR fixes it by making the modal open/close state dependent on component state, while also keeping the /integration route so we can link to the modal.
The flash:
https://github.com/user-attachments/assets/59a2943f-eb6b-4636-8d00-f25dca3cb780
Other information:
Jetpack product discussion
None.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Go to Jetpack > Forms. Click the integrations button in the header to open the modal. Then close the modal and confirm it is smooth with no secondary flash. Try it a few times to confirm, as the original flash often varied in severity.