-
Notifications
You must be signed in to change notification settings - Fork 842
Newsletters Settings (3/3): Add more settings #46473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: newsletter-settings-02-email-settings
Are you sure you want to change the base?
Newsletters Settings (3/3): Add more settings #46473
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
e84ef64 to
52b566f
Compare
Adds some configuration screens for email newsletters including paid newsletters, categories etc. This has been split out from #46136 and is the third of three PRs.
- Add same-origin credentials to category fetch for better security - Add console.error logging for better debugging - Add setError(null) on successful saves to clear previous errors - Use translatable strings for all error messages
d5e1427 to
1bac753
Compare
This is part of solving DOTCOM-15286 and has been split out from the original PR (#46136) in the hope it makes the changes easier to review. It is the third of three PRs (previously #46470, #46471).
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: