-
Notifications
You must be signed in to change notification settings - Fork 53
Add CLI site create/start logs to Studio console #2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/studio-cli-i2
Are you sure you want to change the base?
Add CLI site create/start logs to Studio console #2298
Conversation
gcsecsey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the logging @bcotrim! 🙌
I confirm that I see the logs when adding or starting a site.
However, I couldn't get the WP CLI output to get logged in the Studio console. In another tab, I tested listing the site plugins:
node dist/cli/main.js wp plugin list --path ~/Studio/my-wordpress-website-7
But I only see the output in the original tab.
|
@gcsecsey thanks for reviewing and testing. |
gcsecsey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gcsecsey thanks for reviewing and testing. Did you run those WP CLI from a terminal outside of Studio? If that's the case we don't capture those logs. If you run the WP CLI from the Assistant tab for example, you should see the logs in Studio. Sorry if the instructions weren't clear, I've updated them.
Thanks @bcotrim for updating the steps. Yes indeed, earlier I tried running the CLI commands from another terminal tab. I now tested running it through the Assistant, and this works great, I can see the output in the console.


Related issues
Proposed Changes
logPrefixoption toexecuteCliCommandto identify which site the logs belong to[CLI - {siteId}]prefixcli-site-creator.ts)cli-server-process.ts)site-server.ts)This restores the logging behavior that was available before switching to CLI for site create/start operations, making debugging easier.
Testing Instructions
npm start[CLI - {siteId}]Pre-merge Checklist