Studio CLI: Add bundled Node binary and fix Windows popup #2303
+241
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/download-node-binary.sh
Outdated
Contributor
There was a problem hiding this comment.
To make this more portable, let's do it in JS instead.
bcotrim
force-pushed
the
stu-1148-investigate-site-create-performance
branch
from
75bccac to
dd6bce1
Compare
bcotrim
changed the title
nightnei
approved these changes
Dec 24, 2025
Contributor
nightnei
left a comment
nightnei
left a comment
There was a problem hiding this comment.
The code looks great and works as expected:
- I don't see popup on windows anymore.
- But, I encounter x2 difference in time between CLI and Studio, is it expected?
macOS:
CLI: 6 sec
Studio: 14 sec
Windows:
CLI: 1:40
Studio: 2:50
| const nvmrcPath = path.join( __dirname, '..', '.nvmrc' ); | ||
| if ( fs.existsSync( nvmrcPath ) ) { | ||
| const version = fs.readFileSync( nvmrcPath, 'utf-8' ).trim(); | ||
| // Ensure version starts with 'v' |
Contributor
There was a problem hiding this comment.
The code looks self-explanatory
Suggested change
| // Ensure version starts with 'v' |
| export function getBundledNodeBinaryPath(): string { | ||
| const nodeBinaryName = process.platform === 'win32' ? 'node.exe' : 'node'; | ||
|
|
||
| if ( process.env.NODE_ENV === 'development' || process.env.NODE_ENV === 'test' ) { |
Contributor
There was a problem hiding this comment.
I am thinking - should we keep it only for tests? To have it used in development, to work with the same as in prod, to avoid if in prod something will be unexpectedly broken?
Suggested change
| if ( process.env.NODE_ENV === 'development' || process.env.NODE_ENV === 'test' ) { | |
| if ( process.env.NODE_ENV === 'test' ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Add bundled Node.js binary - The CLI now uses a bundled Node.js binary instead of relying on the Electron run as Node.
Fix Windows terminal popup - Patched the
ps-manpackage to addwindowsHide: trueto spawn calls. This prevents a brief console window popup (showingC:\WINDOWS\system32\tasklist) when running CLI commands on Windows.Testing Instructions
Windows
npm run cli:buildnode dist/cli/main.js site create --name=test-sitemacOS
npm run cli:buildnode dist/cli/main.js site create --name=test-sitePre-merge Checklist