Skip to content

Conversation

@nightnei
Copy link
Contributor

@nightnei nightnei commented Dec 24, 2025

Related issues

Proposed Changes

  1. This PR fixes mentioned bug with texts which has 2+ lines
  2. Also, I noticed broken "Open site" link (see testing instructions), so it fixes it too

Testing Instructions

Apply the next diff:

diff --git a/src/components/content-tab-overview.tsx b/src/components/content-tab-overview.tsx
index d47aa219..5474c3a2 100644
--- a/src/components/content-tab-overview.tsx
+++ b/src/components/content-tab-overview.tsx
@@ -208,7 +208,7 @@ export function ContentTabOverview( { selectedSite }: ContentTabOverviewProps )
        const thumbnailImage = (
                <img
                        onError={ () => setIsThumbnailError( true ) }
-                       onLoad={ () => setIsThumbnailError( false ) }
+                       onLoad={ () => setIsThumbnailError( true ) }
                        className="w-full h-full"
                        src={ thumbnailData || '' }
                        alt={ themeDetails?.name }
  1. Create a site and open Overview
  2. Mouseover on preview
  3. Assert that it looks good
BEFORE AFTER
Screenshot 2025-12-24 at 22 40 55 Screenshot 2025-12-24 at 22 41 49
  1. Change language to "Українська"
  2. Assert that it's centered
BEFORE AFTER
Screenshot 2025-12-24 at 22 43 29 Screenshot 2025-12-24 at 22 42 55

@nightnei nightnei requested a review from a team December 24, 2025 22:43
@nightnei nightnei self-assigned this Dec 24, 2025
@github-actions
Copy link
Contributor

📊 Performance Test Results

Comparing 475e20b vs trunk

site-editor

Metric trunk 475e20b Diff Change
load 10971.00 ms 7739.00 ms -3232.00 ms 🟢 -29.5%

site-startup

Metric trunk 475e20b Diff Change
siteCreation 17363.00 ms 16314.00 ms -1049.00 ms 🟢 -6.0%
siteStartup 7009.00 ms 7042.00 ms +33.00 ms 🔴 0.5%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works as expected. LGTM 👍

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants