Skip to content

Conversation

@gavande1
Copy link
Contributor

@gavande1 gavande1 commented Dec 25, 2025

Related issues

Proposed Changes

  • Do not display the "What's new" modal on the onboarding screen if no sites have been created.

Testing Instructions

  • Checkout trunk branch
  • Delete or move your existing appdata-v1.json. We need fresh installation for testing. It exists at ~/Library/Application Support/Studio
  • Apply following patch to force showing the modal on empty screen.
diff --git a/src/modules/whats-new/hooks/use-last-seen-version.tsx b/src/modules/whats-new/hooks/use-last-seen-version.tsx
index e2bb55e4..24047caf 100644
--- a/src/modules/whats-new/hooks/use-last-seen-version.tsx
+++ b/src/modules/whats-new/hooks/use-last-seen-version.tsx
@@ -33,7 +33,7 @@ export function useLastSeenVersion(): UseLastSeenVersion {
 
        return {
                lastSeenVersion,
-               isNewVersion,
+               isNewVersion: true,
                updateLastSeenVersion,
        };
 }
  • Run npm start
  • You will be shown onboarding screen that will ask to login to WordPress.com account.
  • Click on "Skip" button on right bottom
  • You will see the "What's new" modal. Don't close it yet.
  • Now checkout to this branch.
  • Refresh the window, Assert that "What's new" modal is not shown.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gavande1 gavande1 self-assigned this Dec 25, 2025
@gavande1 gavande1 requested a review from a team December 25, 2025 10:02
@github-actions
Copy link
Contributor

📊 Performance Test Results

Comparing 4705c1b vs trunk

site-editor

Metric trunk 4705c1b Diff Change
load 13918.00 ms 7147.00 ms -6771.00 ms 🟢 -48.6%

site-startup

Metric trunk 4705c1b Diff Change
siteCreation 24495.00 ms 19883.00 ms -4612.00 ms 🟢 -18.8%
siteStartup 8046.00 ms 9049.00 ms +1003.00 ms 🔴 12.5%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants