Studio: Indicate site deletion with loading spinner #2331
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katinthehatsite
changed the title
Contributor
📊 Performance Test ResultsComparing f58638e vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
gavande1
approved these changes
Dec 29, 2025
Contributor
gavande1
left a comment
gavande1
left a comment
There was a problem hiding this comment.
I have tested this and works as expected. LGTM 👍
nightnei
approved these changes
Dec 29, 2025
Contributor
nightnei
left a comment
nightnei
left a comment
There was a problem hiding this comment.
LGTM and works as expected 👍
added 2 commits
December 29, 2025 16:05
…-spinner-when-delete-site
Contributor
|
I restarted the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes STU-1179
Proposed Changes
This PR ensures that we display a loading spinner when a site is being deleted to make it consistent with other actions such as site creation:
Testing Instructions
npm startSettingstabDelete sitePre-merge Checklist