-
Notifications
You must be signed in to change notification settings - Fork 7
Feature Banjo #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raelcarlos
wants to merge
8
commits into
AvaliaSystems:master
Choose a base branch
from
kinderkike:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature Banjo #45
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
660c9b0
'Comeco'
d27950c
kikinho
710c711
Merge https://github.com/kinderkike/Samba into feature-banjo
64380b1
closes #1
3cda132
Implementação do volume do banjo.
lucasdsil 28b1696
simulando conflito
418c585
Corrigindo conflito
9c3adaa
closes #1
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17
Samba-build/Samba-code/src/main/java/io/avalia/samba/Banjo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package io.avalia.samba; | ||
|
|
||
| public class Banjo implements IInstrument { | ||
|
|
||
| public String play() { | ||
| return "dumdum"; | ||
| } | ||
|
|
||
| public int getSoundVolume() { | ||
| return 500; | ||
| } | ||
|
|
||
| public String getColor() { | ||
| return "white"; | ||
| } | ||
|
|
||
| } |
44 changes: 44 additions & 0 deletions
44
Samba-build/Samba-tests/src/test/java/io/avalia/samba/BanjoTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package io.avalia.samba; | ||
|
|
||
| import org.junit.Assert; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import org.junit.Test; | ||
|
|
||
| public class BanjoTest { | ||
|
|
||
| @Test | ||
| public void thereShouldBeAnIInstrumentInterfaceAndABanjoClass() { | ||
| IInstrument banjo = new Banjo(); | ||
| assertNotNull(banjo); | ||
| } | ||
|
|
||
| @Test | ||
| public void itShouldBePossibleToPlayAnInstrument() { | ||
| IInstrument banjo = new Banjo(); | ||
| String sound = banjo.play(); | ||
| assertNotNull(sound); | ||
| } | ||
|
|
||
| @Test | ||
| public void aBanjoShouldMakePouet() { | ||
| IInstrument banjo = new Banjo(); | ||
| String sound = banjo.play(); | ||
| Assert.assertEquals("dumdum", sound); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldHaveAMediumSoundVolume() { | ||
| IInstrument banjo = new Banjo(); | ||
| int soundVolume = banjo.getSoundVolume(); | ||
| Assert.assertEquals(500, soundVolume); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldHaveWhiteColor() { | ||
| IInstrument banjo = new Banjo(); | ||
| String color = banjo.getColor(); | ||
| Assert.assertEquals("white", color); | ||
| } | ||
|
|
||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it make "pouet" or "dumdum" ?