Skip to content

Update ControlCatalog to use the Page system#21044

Open
emmauss wants to merge 5 commits intomasterfrom
page_control_catalog_sample_update
Open

Update ControlCatalog to use the Page system#21044
emmauss wants to merge 5 commits intomasterfrom
page_control_catalog_sample_update

Conversation

@emmauss
Copy link
Copy Markdown
Contributor

@emmauss emmauss commented Mar 30, 2026

Updates the main view in ControlCatalog, removing the dependency on the custom HamburgerMenu control in ControlSamples.
All pages have also been updated to use their respective Page type.

Old.

Screen.Recording.2026-03-30.121842.mp4

New

Screen.Recording.2026-03-30.150102.mp4

@avaloniaui-bot
Copy link
Copy Markdown

You can test this PR using the following package version. 12.0.999-cibuild0064283-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jsuarezruiz jsuarezruiz self-requested a review March 30, 2026 16:16
@@ -1,6 +1,7 @@
<UserControl xmlns="https://github.com/avaloniaui"
<ContentPage Theme="{StaticResource ScrollPage}" xmlns="https://github.com/avaloniaui"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page should not use ScrollPage, this will break the ListBox virtualization below.

new PageItem("Calendar",() => new CalendarPage()),
new PageItem("Canvas",() => new CanvasPage()),
new PageItem("CommandBar",() => new CommandBarPage()),
new PageItem("Carousel",() => new CarouselDemoPage()),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect page for Carousel, duplicated with the one for CarouselPage.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jsuarezruiz
Copy link
Copy Markdown
Member

Just added in 467bc14 icons:
image

@avaloniaui-bot
Copy link
Copy Markdown

You can test this PR using the following package version. 12.0.999-cibuild0064325-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link
Copy Markdown

You can test this PR using the following package version. 12.0.999-cibuild0064327-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link
Copy Markdown

You can test this PR using the following package version. 12.0.999-cibuild0064331-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link
Copy Markdown

You can test this PR using the following package version. 12.0.999-cibuild0064347-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Copy Markdown
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll wait for @jsuarezruiz's approval before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants