Announce changes to live regions on macOS#21045
Open
kirb wants to merge 2 commits intoAvaloniaUI:masterfrom
Open
Announce changes to live regions on macOS#21045kirb wants to merge 2 commits intoAvaloniaUI:masterfrom
kirb wants to merge 2 commits intoAvaloniaUI:masterfrom
Conversation
It is necessary to manually request announcement of the new name of a live region, alongside posting the general kAXLiveRegionChangedNotification.
kirb
force-pushed
the
feature/live-region-announce
branch
from
36882b1 to
f9f6491
Compare
Contributor
Author
|
Force pushed a rebase due to the bad merge in between commits. This is now cleanly based on top of master. (Seems that pulled in a bunch of people as participants - sorry!) |
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
It is necessary to request announcement of the new contents of a live region, alongside posting the more general
kAXLiveRegionChangedNotification, otherwise the live setting has no effect. This adds the announcement notification.What is the current behavior?
Live regions are correctly attributed as live, and post notifications when they change. Assistive tools could make use of these traits (I don’t know the details of this), but the text does not get read out by VoiceOver or a Braille display.
What is the updated/expected behavior with this PR?
Changes to the
Nameof live regions are announced using the specified assertiveness.How was the solution implemented (if it's not obvious)?
When the
Nameof an element that specifies a live mode changes, we postNSAccessibilityAnnouncementRequestedNotificationwith this text.Politemaps toNSAccessibilityPriorityMediumand will queue to be announced after the current item;Assertivemaps toNSAccessibilityPriorityHighand will interrupt any current announcement. This matches Chromium’s implementation ofaria-liveon macOS.Checklist
Breaking changes
n/a
Obsoletions / Deprecations
n/a
Fixed issues
n/a