Conversation
|
You can test this PR using the following package version. |
| { | ||
| base.OnAttachedToVisualTree(e); | ||
|
|
||
| CleanUpSubscriptions(); |
There was a problem hiding this comment.
CleanUpSubscriptions() already nulls _topLevel and _insetManager, the next block never runs?. Can verify? If is the case, ScalingChanged is subscribed below but never unsubscribed in the detach path. That causes duplicate callbacks after a detach/reattach to the same live TopLevel, and can also keep the host alive through the old TopLevel. Can we move the ScalingChanged cleanup into CleanUpSubscriptions() or detach it before calling that helper?`
|
You can test this PR using the following package version. |
What does the pull request do?
Fixes safe area calculation for DrawerPage and applies safe area to drawer header and drawer footer.
PageNavigationHostalso listens on scaling changed event from toplevel to update the child page safe area.What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues