Feat/view bidders #1
Conversation
| import React, { Component } from 'react'; | ||
| import request from 'request'; | ||
| import { BrowserRouter as Router, Route, Link } from "react-router-dom"; | ||
| import classnames from 'classnames'; |
There was a problem hiding this comment.
classnames is imported but it is never used
| constructor(props) { | ||
| super(props); | ||
|
|
||
| var res = []; |
There was a problem hiding this comment.
Fetching data in the constructor may result to rendering witout having all the data . This should be done in the ComponentDidMount method
| super(props); | ||
|
|
||
| var res = []; | ||
| request('http://bidders.mytestcompany.com', function (error, response, body) { |
There was a problem hiding this comment.
Request package has been deprecated. Better use axios or fetch.
| var live = []; | ||
| var created = []; | ||
|
|
||
| for (var i = 1; i < res.length; i++) { |
There was a problem hiding this comment.
This loop does not include the last item of the array.
| <hr className="bottom-spacing-2x top-spacing-2x" /> | ||
| </div> | ||
| </div> | ||
| <div className="column small-12 medium-6 bottom-spacing-1x"> |
There was a problem hiding this comment.
The two columns should be wrapped in a row so they are both in the same line.
| <ul> | ||
| <li> | ||
| <a class="active" href="/bidders"> | ||
| <Link to="/bidders" activeClass="active"> |
There was a problem hiding this comment.
activeClass is unnecessary
| <li> | ||
| <a class="active" href="/bidders"> | ||
| <Link to="/bidders" activeClass="active"> | ||
| <i class="icon location_world"></i> |
There was a problem hiding this comment.
class should be changed to className
| <div className="column small-12 medium-6 bottom-spacing-1x"> | ||
| <div data-testid="created-bidders-list" className="card" style={{height: '100%'}}> | ||
| <p className="card__title">1. Created </p> | ||
| {this.state.created.map(function (bidder) { |
There was a problem hiding this comment.
Both map functions should have a unique key id
baspavlou
left a comment
baspavlou
left a comment
There was a problem hiding this comment.
Please review the mentioned changes.
No description provided.