-
Notifications
You must be signed in to change notification settings - Fork 0
Add Java Samples #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment and a suggested reword, otherwise LGTM
README.md
Outdated
| mvn exec:java | ||
| ``` | ||
|
|
||
| **Note:** Do not use VS Code's "Run" button directly. Always run through Maven to ensure proper classpath and resource loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Note:** Do not use VS Code's "Run" button directly. Always run through Maven to ensure proper classpath and resource loading. | |
| **Note:** Do not use VS Code's "Run" button directly. Run examples through Maven to ensure proper classpath and resource loading. |
reword to make sure this isn't taken as "always even outside these examples" guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - done
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ### Hibernate Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to other projects: Would be good to include a quick section about how they can use it in their own project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not building a new library for Java and just directing users to use the existing plug-in, I pointed them to the same setup process used for running the samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Add sample Java scripts showcasing Entra ID connection for
JDBCandHibernate