Skip to content

Remove hardcoded gpt-4o-mini default from consumption agent loop manifest#8908

Open
Bhavd13 wants to merge 1 commit intomainfrom
modelid
Open

Remove hardcoded gpt-4o-mini default from consumption agent loop manifest#8908
Bhavd13 wants to merge 1 commit intomainfrom
modelid

Conversation

@Bhavd13
Copy link
Contributor

@Bhavd13 Bhavd13 commented Mar 12, 2026

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Removes the hardcoded default: 'gpt-4o-mini' from the modelId parameter in the consumption agent loop manifest. The backend now handles defaulting to a valid model when modelId is not provided.

Impact of Change

  • Users: Workflows will no longer silently default to gpt-4o-mini; the backend determines the appropriate model.
  • Developers: No API changes.
  • System: No performance or architecture impact.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Standalone designer — verified no build errors

Contributors

@Bhavd13

Screenshots/Videos

The code view will no longer show the default model Id value
image

Copilot AI review requested due to automatic review settings March 12, 2026 07:44
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: Remove hardcoded gpt-4o-mini default from consumption agent loop manifest
  • Issue: None — title is clear and specific about what was changed.
  • Recommendation: Title is good. (Optionally you can mention the file path for extra clarity, e.g., ... from libs/logic-apps-shared/.../agentloop.ts.)

Commit Type

  • Properly selected (fix).
  • Commit type note: Only one commit type selected which is correct for this change.

Risk Level

  • Risk level assessment: The PR is a small manifest change (1 line removed) and the author selected Low. The repository also has the label risk:low applied. This aligns with the code diff, so the selected risk is appropriate.

What & Why

  • Current: Remov(es) the hardcoded default: 'gpt-4o-mini' from the modelId parameter in the consumption agent loop manifest. Backend will handle defaulting to a valid model when modelId is not provided.
  • Issue: None — explanation is concise and matches the diff.
  • Recommendation: Good. If you want, explicitly reference the exact file changed (libs/logic-apps-shared/src/designer-client-services/lib/consumption/manifests/agentloop.ts) in the What & Why to make it easier for reviewers.

Impact of Change

  • The Impact section is appropriate and concise.
  • Recommendation:
    • Users: Workflows will no longer silently default to gpt-4o-mini; the backend determines the appropriate model.
    • Developers: No API changes.
    • System: No performance or architecture impact.

Test Plan

  • Test plan assessment: Manual testing completed and "Stand-alone designer — verified no build errors" is provided. Given the minimal nature of this manifest-only change and that no runtime logic was added, manual verification is acceptable.
  • Recommendation: If feasible, add a small unit/e2e test in the future that validates manifest schema or ensures the UI doesn't render hardcoded defaults. This is optional for this small change but improves future safety.

Contributors

  • Contributors assessment: @Bhavd13 is listed. Good — credit present.

Screenshots/Videos

  • Screenshots assessment: A screenshot is provided showing the UI change. Good.

Summary Table

Section Status Recommendation
Title Title is clear. Optionally add file path.
Commit Type Correctly set to fix.
Risk Level risk:low matches the small one-line change.
What & Why Good; consider referencing the file path.
Impact of Change Adequate and correct.
Test Plan Manual testing ok; consider adding automated test later.
Contributors @Bhavd13 listed.
Screenshots/Videos Screenshot included.

Final message: This PR passes the PR title/body checklist. The change is a single-line removal of a hardcoded default in a manifest and correctly labeled as risk:low. Please consider adding (optionally) a note in the What & Why that names the exact file changed and, if feasible, a lightweight automated test in a follow-up to guard against regressions. Thank you!


Last updated: Thu, 12 Mar 2026 07:47:53 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the hardcoded gpt-4o-mini default from the Consumption agent loop operation manifest so model selection/defaulting is handled by the backend when modelId isn’t provided.

Changes:

  • Removed the default: 'gpt-4o-mini' value from the modelId input in the Consumption agent loop manifest.

@Bhavd13 Bhavd13 added the risk:low Low risk change with minimal impact label Mar 12, 2026
@github-actions
Copy link

📊 Coverage Check

No source files changed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants