Fixes #355 Add near full support for user-defined types #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GABRIELNGBTUC
changed the title
Author
|
@BernieWhite Would it be possible to look at it when you have some time? When this PR will be merged, I will also look to implement #195 |
…an also be a built-in type
Author
|
Pinging @vicperdana @BernieWhite again |
Author
|
Pinging @vicperdana @BernieWhite again |
Author
|
Pinging @vicperdana @BernieWhite again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds support for user-defined types by adding the UDTs present in the ARM file inside the markdown file and providing a link to the used UDT definition for outputs returning a UDT .
The only missing information are from additional decorators such as
sealedor support for the source file location when the type is imported.Will fix #355
There is also a known bug where links to some imported types (ie:
[#definitions/_1.MyCustomType][#_1.mycustomtype]) may not work on all markdown engines. In the visual studio code text editor, two extensions I tried could not navigate to the referenced type on click. However, on ADO code wiki the link works as expected.PR Checklist