-
Notifications
You must be signed in to change notification settings - Fork 633
FEAT: adding underlying_model for target identification #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsong468
wants to merge
9
commits into
Azure:main
Choose a base branch
from
jsong468:model_name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+183
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbolor21
reviewed
Dec 9, 2025
jbolor21
reviewed
Dec 9, 2025
Contributor
|
great work Justin, I think this makes a lot of sense how the deployment name could be arbitrary but the actual type of deployment is useful esp for metrics! |
rlundeen2
reviewed
Dec 12, 2025
rlundeen2
reviewed
Dec 12, 2025
hannahwestra25
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft adds
underlying_modelparam and environment variable which differs frommodel_namewhich is often actually the deployment name (i.e. Azure endpoints). Theunderlying_modelwill give better insight into the actual model used rather than the deployment and will be useful for identifying scoring configurations and their associated evaluation metrics (since deployment names can be custom made).underlying_modelcan be passed in explicitly as a param in the constructor or set via environment variable (e.g.OPENAI_CHAT_UNDERLYING_MODEL)UPDATE: We are not implementing method to get the underlying model name programmatically in this PR.
This also adds a methodget_underlying_model_asyncto get the underlying model name programmatically for certain OpenAI targets that return themodelin the response (by sending a very simple prompt, I couldn't get GETs to work...). (The reason why it is not done automatically upon get_identifier is because it seems like overkill to make the method async throughout the codebase. We also can't call it upon instantiation because async inits aren't a thing). So, calling this method is manual, and the preferred way would be through environment variable or passed value, which would flow into the identifier.Tests and Documentation
Unit tests added