-
Notifications
You must be signed in to change notification settings - Fork 633
DOC reorganize converter docs #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romanlutz
wants to merge
11
commits into
Azure:main
Choose a base branch
from
romanlutz:romanlutz/organize_converters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e21cb8e
reorganize converter docs
romanlutz dadcbb3
linting
romanlutz 3ab06d3
Merge branch 'main' of https://github.com/Azure/PyRIT into romanlutz/…
romanlutz e737e61
more linting
romanlutz 5982ebd
linting, links
romanlutz 52b1037
fix unit tests
romanlutz 2133647
Merge branch 'main' of https://github.com/Azure/PyRIT into romanlutz/…
romanlutz 917341b
lint
romanlutz d841270
Merge branch 'main' of https://github.com/Azure/PyRIT into romanlutz/…
romanlutz 4514d26
Update doc/code/converters/1_text_to_text_converters.py
romanlutz d1ee2a7
Add subclass validation to enforce INPUT_TYPES and OUTPUT_TYPES for P…
rlundeen2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this organization a lot! this is much more streamlined. I have a slight preference to remove 7_human_converter so that human converter is just an example in the 1_text_to_text_converters notebook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interaction mode is VERY different, though, and it prevents us from running it in automation. Plus, I imagine with the GUI this will actually disappear.