Skip to content

Conversation

@jeremymeng
Copy link
Member

No description provided.

@jeremymeng jeremymeng marked this pull request as draft July 7, 2025 22:01
@jeremymeng
Copy link
Member Author

Here's what it looks like for migrating to pnpm

@qiaozha
Copy link
Member

qiaozha commented Jul 9, 2025

@jeremymeng could you update the ci.yaml/release.yaml? I think those have references to the rush scripts.

@jeremymeng
Copy link
Member Author

@jeremymeng could you update the ci.yaml/release.yaml? I think those have references to the rush scripts.

@qiaozha I have updated files under .scripts and no longer see any references of "rush". I don't know for sure though whether replacing them with pnpm works as expected.

@qiaozha qiaozha added the P1 priority 1 label Aug 20, 2025
@jeremymeng jeremymeng marked this pull request as ready for review October 31, 2025 16:37
@jeremymeng
Copy link
Member Author

Looks that CI checks were all passing. I don't know whether we have other places that is not in this repo where we still build using rush. If not I think it is good to merge.

displayName: Install @typespec/compiler@next
- script: npx @azure-tools/typespec-bump-deps@latest pnpm-config.json --add-rush-overrides
workingDirectory: $(Build.SourcesDirectory)/common/config/rush
displayName: "Override global pnpm-config to dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this configuration is for rush, I verified this change does not affect the nightly CI.

"pnpm": ">=10.12.1"
},
"pnpm": {
"overrides": {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check if we need to add this global overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 priority 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants