Property flatten support in modular #3586
Draft
+564
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
changed the title
joheredi
reviewed
Nov 14, 2025
| if (!property.flatten) { | ||
| return false; | ||
| } | ||
| return ["properties"].includes(property.name); |
Member
There was a problem hiding this comment.
If I understand correctly, this is to only honor the @flattenProperty decorator if the property being flattened is called "property"... Can we just flatten any property decorated with @flattenProperty? The decorator is already deprecated/legacy so that should be enough warning for customers, this way we don't put ourselves into a corner
Member
There was a problem hiding this comment.
If we're still concerned about folks using this in a breaking way (e.g. another ARM service with flatten use that would cause conflicts) I think we could add another emitter flag to gate this behavior. I don't believe (though we should check) that Compute specifically has flatten use other than properties
MaryGao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.