Skip to content

Fix formatting inconsistency #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix formatting inconsistency #3603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86899b4
Fix formatting inconsistency
JialinHuang803 Nov 17, 2025
a5263b9
Merge remote-tracking branch 'origin/main' into formattingerror
JialinHuang803 Nov 18, 2025
545cab5
Update smoke test
JialinHuang803 Nov 18, 2025
bd2027b
Update tests
JialinHuang803 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 1 addition & 2 deletions ...test/NetworkAnalytics.Management/generated/typespec-ts/sdk/test/arm-test/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ function ignoreNiseSinonEval(warning) {
return (
warning.code === "EVAL" &&
warning.id &&
(warning.id.includes("node_modules/nise") ||
warning.id.includes("node_modules/sinon")) === true
(warning.id.includes("node_modules/nise") || warning.id.includes("node_modules/sinon")) === true
);
}

Expand Down
20 changes: 8 additions & 12 deletions ...ment/generated/typespec-ts/sdk/test/arm-test/samples-dev/dataProductsAddUserRoleSample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,14 @@ async function dataProductsAddUserRoleMaximumSetGen(): Promise<void> {
const credential = new DefaultAzureCredential();
const subscriptionId = "00000000-0000-0000-0000-00000000000";
const client = new NetworkAnalyticsApi(credential, subscriptionId);
const result = await client.dataProducts.addUserRole(
"aoiresourceGroupName",
"dataproduct01",
{
roleId: "00000000-0000-0000-0000-00000000000",
principalId: "00000000-0000-0000-0000-00000000000",
userName: "UserName",
dataTypeScope: ["scope"],
principalType: "User",
role: "Reader",
},
);
const result = await client.dataProducts.addUserRole("aoiresourceGroupName", "dataproduct01", {
roleId: "00000000-0000-0000-0000-00000000000",
principalId: "00000000-0000-0000-0000-00000000000",
userName: "UserName",
dataTypeScope: ["scope"],
principalType: "User",
role: "Reader",
});
console.log(result);
}

Expand Down
89 changes: 41 additions & 48 deletions ...anagement/generated/typespec-ts/sdk/test/arm-test/samples-dev/dataProductsCreateSample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,57 +14,50 @@ async function dataProductsCreateMaximumSetGen(): Promise<void> {
const credential = new DefaultAzureCredential();
const subscriptionId = "00000000-0000-0000-0000-00000000000";
const client = new NetworkAnalyticsApi(credential, subscriptionId);
const result = await client.dataProducts.create(
"aoiresourceGroupName",
"dataproduct01",
{
properties: {
provisioningState: "Succeeded",
publisher: "Microsoft",
product: "MCC",
majorVersion: "1.0.0",
owners: ["abc@micros.com"],
redundancy: "Disabled",
purviewAccount: "testpurview",
purviewCollection: "134567890",
privateLinksEnabled: "Disabled",
publicNetworkAccess: "Enabled",
customerManagedKeyEncryptionEnabled: "Enabled",
customerEncryptionKey: {
keyVaultUri: "https://KeyVault.vault.azure.net",
keyName: "keyName",
keyVersion: "keyVersion",
},
networkacls: {
virtualNetworkRule: [
{
id: "/subscriptions/subscriptionId/resourcegroups/resourceGroupName/providers/Microsoft.Network/virtualNetworks/virtualNetworkName/subnets/subnetName",
action: "Allow",
state: "",
},
],
ipRules: [{ value: "1.1.1.1", action: "Allow" }],
allowedQueryIpRangeList: ["1.1.1.1"],
defaultAction: "Allow",
},
managedResourceGroupConfiguration: {
name: "managedResourceGroupName",
location: "eastus",
},
currentMinorVersion: "1.0.1",
consumptionEndpoints: {},
const result = await client.dataProducts.create("aoiresourceGroupName", "dataproduct01", {
properties: {
provisioningState: "Succeeded",
publisher: "Microsoft",
product: "MCC",
majorVersion: "1.0.0",
owners: ["abc@micros.com"],
redundancy: "Disabled",
purviewAccount: "testpurview",
purviewCollection: "134567890",
privateLinksEnabled: "Disabled",
publicNetworkAccess: "Enabled",
customerManagedKeyEncryptionEnabled: "Enabled",
customerEncryptionKey: {
keyVaultUri: "https://KeyVault.vault.azure.net",
keyName: "keyName",
keyVersion: "keyVersion",
},
identity: {
type: "UserAssigned",
userAssignedIdentities: {
"/subscriptions/subid/resourceGroups/resourceGroupName/providers/Microsoft.ManagedIdentity/userAssignedIdentities/id1":
{},
},
networkacls: {
virtualNetworkRule: [
{
id: "/subscriptions/subscriptionId/resourcegroups/resourceGroupName/providers/Microsoft.Network/virtualNetworks/virtualNetworkName/subnets/subnetName",
action: "Allow",
state: "",
},
],
ipRules: [{ value: "1.1.1.1", action: "Allow" }],
allowedQueryIpRangeList: ["1.1.1.1"],
defaultAction: "Allow",
},
tags: { userSpecifiedKeyName: "userSpecifiedKeyValue" },
location: "eastus",
managedResourceGroupConfiguration: { name: "managedResourceGroupName", location: "eastus" },
currentMinorVersion: "1.0.1",
consumptionEndpoints: {},
},
);
identity: {
type: "UserAssigned",
userAssignedIdentities: {
"/subscriptions/subid/resourceGroups/resourceGroupName/providers/Microsoft.ManagedIdentity/userAssignedIdentities/id1":
{},
},
},
tags: { userSpecifiedKeyName: "userSpecifiedKeyValue" },
location: "eastus",
});
console.log(result);
}

Expand Down
4 changes: 1 addition & 3 deletions ...erated/typespec-ts/sdk/test/arm-test/samples-dev/dataProductsListByResourceGroupSample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ async function dataProductsListByResourceGroupMaximumSetGenGeneratedByMinimumSet
const subscriptionId = "00000000-0000-0000-0000-00000000000";
const client = new NetworkAnalyticsApi(credential, subscriptionId);
const resArray = new Array();
for await (const item of client.dataProducts.listByResourceGroup(
"aoiresourceGroupName",
)) {
for await (const item of client.dataProducts.listByResourceGroup("aoiresourceGroupName")) {
resArray.push(item);
}

Expand Down
34 changes: 15 additions & 19 deletions ...anagement/generated/typespec-ts/sdk/test/arm-test/samples-dev/dataProductsUpdateSample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,27 +14,23 @@ async function dataProductsUpdateMaximumSetGen(): Promise<void> {
const credential = new DefaultAzureCredential();
const subscriptionId = "00000000-0000-0000-0000-00000000000";
const client = new NetworkAnalyticsApi(credential, subscriptionId);
const result = await client.dataProducts.update(
"aoiresourceGroupName",
"dataproduct01",
{
identity: {
type: "UserAssigned",
userAssignedIdentities: {
"/subscriptions/subid/resourceGroups/resourceGroupName/providers/Microsoft.ManagedIdentity/userAssignedIdentities/id1":
{},
},
},
tags: { userSpecifiedKeyName: "userSpecifiedKeyValue" },
properties: {
owners: ["abc@micros.com", "def@micros.com"],
purviewAccount: "testpurview",
purviewCollection: "134567890",
privateLinksEnabled: "Disabled",
currentMinorVersion: "1.0.1",
const result = await client.dataProducts.update("aoiresourceGroupName", "dataproduct01", {
identity: {
type: "UserAssigned",
userAssignedIdentities: {
"/subscriptions/subid/resourceGroups/resourceGroupName/providers/Microsoft.ManagedIdentity/userAssignedIdentities/id1":
{},
},
},
);
tags: { userSpecifiedKeyName: "userSpecifiedKeyValue" },
properties: {
owners: ["abc@micros.com", "def@micros.com"],
purviewAccount: "testpurview",
purviewCollection: "134567890",
privateLinksEnabled: "Disabled",
currentMinorVersion: "1.0.1",
},
});
console.log(result);
}

Expand Down
Loading
Loading