Skip to content

Conversation

@sivakami-projects
Copy link
Contributor

@sivakami-projects sivakami-projects commented Oct 23, 2025

test:
This PR introduces a new Azure DevOps pipeline for running long-term tests on AKS Swift v2 clusters.
The pipeline automates the creation of AKS clusters and the necessary networking infrastructure.
Pipeline link

Create 2 AKS clusters and attaches node pool with 2 nodes with 8 NICs on each node. All are AKS managed Linux nodes.
Creates 4 VNets and subnets.
Peers three of the four VNets.
Creates 2 storage accounts with private endpoints.
Adds NSG rules to prevent network connectivity between pods on two subnets in the same Vnet.
Initial PR - #4092

Creates a parameterized pipeline template that orchestrates AKS cluster creation and networking setup
Implements bash scripts to provision two AKS clusters, virtual networks, network peerings, storage accounts, and network security groups
Configures parallel execution for AKS cluster creation to optimize deployment time

@sivakami-projects sivakami-projects requested a review from a team as a code owner October 23, 2025 19:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Azure DevOps pipeline infrastructure for long-running tests on AKS Swift v2 clusters. The pipeline automates the provisioning of dual AKS clusters with custom networking configurations including VNet peering, private endpoints, and network security groups.

Key changes:

  • Parameterized pipeline template with sequential job dependencies for infrastructure provisioning
  • Six bash scripts for creating resource groups, AKS clusters, VNets, peerings, storage accounts, NSGs, and private endpoints
  • Parallel AKS cluster creation to optimize deployment time

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.pipelines/swiftv2-long-running/template/long-running-pipeline-template.yaml Defines the pipeline template with three jobs: resource group creation, parallel AKS cluster provisioning, and networking/storage setup
.pipelines/swiftv2-long-running/scripts/create_vnets.sh Creates four VNets with multiple subnets using predefined CIDR ranges
.pipelines/swiftv2-long-running/scripts/create_storage.sh Provisions two storage accounts with security configurations and exports their names as pipeline variables
.pipelines/swiftv2-long-running/scripts/create_peerings.sh Establishes bidirectional VNet peerings between three of the four VNets
.pipelines/swiftv2-long-running/scripts/create_pe.sh Creates private DNS zone, links it to VNets, and provisions private endpoint for storage account
.pipelines/swiftv2-long-running/scripts/create_nsg.sh Creates NSG with bidirectional deny rules between two subnets in the same VNet
.pipelines/swiftv2-long-running/scripts/create_aks.sh Creates two AKS clusters in parallel, each with a default node pool and a high-NIC node pool
.pipelines/swiftv2-long-running/pipeline.yaml Main pipeline configuration with parameters for subscription, location, resource group, and VM SKUs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sivakami-projects
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sivakami-projects
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

local CLUSTER=$1
echo "==> Creating AKS cluster: $CLUSTER"

az aks create -g "$RG" -n "$CLUSTER" -l "$LOCATION" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, and the command below it, might be best to move to https://github.com/Azure/azure-container-networking/blob/master/hack/aks/Makefile as a Make target
See

make -C ./hack/aks ${{ parameters.clusterType }} \
for usage

See https://github.com/Azure/azure-container-networking/blob/6c232c8618594bfda4f8b9fbe23b6a6bf422c7a9/.pipelines/pipeline.yaml#L321C8-L321C53 for clusterType variable such as dualstack-byocni-nokubeproxy-up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, as it is, we would not be including the ip-tags we need to avoid SFI items
So I think we should use the cniv1-up target in that Makefile I linked, and add a new target linux-nodepool-up

@sivakami-projects sivakami-projects changed the title Swiftv2 pipeline branch Swiftv2 Long running cluster - test pipeline Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants