-
Couldn't load subscription status.
- Fork 259
Return nil when HNS endpoint ID is empty during deletion #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oint deletion Co-authored-by: behzad-mir <13154712+behzad-mir@users.noreply.github.com>
Co-authored-by: behzad-mir <13154712+behzad-mir@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves an issue where pods get stuck in a delete loop when HNS endpoints are never created during failed ADD calls in Stateless CNI Windows SwiftV1. The fix changes the error handling to treat missing HNS endpoint IDs as a valid state rather than a blocking error.
- Changes
deleteEndpointImplto returnnilinstead of an error whenHnsIdis empty - Downgrades log level from Error to Info since missing HNS ID is now expected
- Aligns behavior with existing
deleteEndpointImplHnsV1anddeleteEndpointImplHnsV2implementations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the changes form go.sum.
Only need to make changes on endpoint_windows.go
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pods stuck in delete loop when HNS endpoint never created during failed ADD calls in Stateless CNI Windows SwiftV1.
Change
Modified
deleteEndpointImplinnetwork/endpoint_windows.goto returnnilinstead of error whenep.HnsIdis empty:This matches existing behavior in both
deleteEndpointImplHnsV1anddeleteEndpointImplHnsV2where missing endpoints returnnilrather than blocking deletion. Log level changed from Error to Info since empty HNS ID is now treated as expected state.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.