Updating .NET item templates to use primary constructors#1716
Draft
mattchenderson wants to merge 1 commit intodevfrom
Draft
Updating .NET item templates to use primary constructors#1716mattchenderson wants to merge 1 commit intodevfrom
mattchenderson wants to merge 1 commit intodevfrom
Conversation
Contributor
|
Hi @mattchenderson , Is this PR ready for review and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the .NET templates to use primary constructors to reduce verbosity a little. The changes here require C#12, which means the .NET 8 SDK or later. If we accept these changes, we must ensure that they don't get added to older versions in the tooling feed, for example. We also need to look at some separation in the Core Tools.
This PR is being open as a draft until those enforcement mechanisms can be properly in place. At time of opening, the tooling feed generator has been updated to skip out-of-support versions. However, there are enough manual changes in that repo that we might need to add extra enforcement - I'm currently thinking of auto-review from Copilot, with an appropriate
copilot-instructions.mdto frame this new requirement and help avoid mistakes. I do not yet have a plan for the Core Tools.