Adding extended location for create firewall #28745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for deploying Azure Firewalls in extended locations (edge zones) by introducing a new -EdgeZone parameter to the New-AzFirewall cmdlet. The key change is that when an EdgeZone is specified, availability zones are automatically set to null, as edge zone deployments do not support availability zones.
Key changes:
- Added
-EdgeZoneparameter toNew-AzFirewallcmdlet with validation that prevents simultaneous specification of both EdgeZone and availability zones - Updated the PSAzureFirewall model to include ExtendedLocation property
- Added comprehensive test coverage for EdgeZone scenarios including CRUD operations, Virtual Hub deployments, and parameter validation
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Network/Network/help/New-AzFirewall.md | Updated cmdlet help documentation to include the new -EdgeZone parameter and added Example 18 demonstrating edge zone deployment |
| src/Network/Network/Models/AzureFirewall/PSAzureFirewall.cs | Added ExtendedLocation property to the PSAzureFirewall model to support edge zone information |
| src/Network/Network/ChangeLog.md | Documented the new EdgeZone parameter feature in the upcoming release notes |
| src/Network/Network/AzureFirewall/NewAzureFirewallCommand.cs | Implemented the EdgeZone parameter with validation logic and ExtendedLocation initialization for both VNet and Virtual Hub firewall deployments |
| src/Network/Network.Test/ScenarioTests/AzureFirewallTests.ps1 | Added three comprehensive test functions covering EdgeZone CRUD operations, Virtual Hub scenarios, and parameter validation |
| src/Network/Network.Test/ScenarioTests/AzureFirewallTests.cs | Registered the new EdgeZone test methods as XUnit test cases |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Looks good but please double check with the tests |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
- Add validation to ensure VirtualNetwork, PublicIpAddress, and ManagementPublicIpAddress are in the same EdgeZone as the firewall when EdgeZone parameter is specified - Update ChangeLog.md with EdgeZone Extended Location parameter support - Validation throws ArgumentException with descriptive error messages for mismatched ExtendedLocations
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure firewalls can be now created in extended locations. Adding a new parameter for create az firewall called -EdgeZone
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.