Add High Speed Interconnect Placement property to VMSS commands #28994
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the High Speed Interconnect Placement property to Virtual Machine Scale Set (VMSS) commands in the Azure PowerShell Compute module. The feature allows users to specify high-speed interconnect placement settings when creating or updating VMSS resources.
Key Changes:
- Added
-HighSpeedInterconnectPlacementparameter to three VMSS cmdlets:New-AzVmss,New-AzVmssConfig, andUpdate-AzVmss - Implemented backend support in strategy and method classes to properly handle and propagate the new parameter
- Added comprehensive test coverage with a new test function
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Compute/Compute/help/Update-AzVmss.md | Updated help documentation to include the new -HighSpeedInterconnectPlacement parameter |
| src/Compute/Compute/help/New-AzVmssConfig.md | Added parameter documentation for -HighSpeedInterconnectPlacement in VMSS configuration cmdlet |
| src/Compute/Compute/help/New-AzVmss.md | Documented the new parameter in the VMSS creation cmdlet help |
| src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs | Extended strategy methods to accept and apply highSpeedInterconnectPlacement parameter |
| src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs | Added parameter definition with PSArgumentCompleter and wired it through to the strategy layer |
| src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs | Added parameter to the Update-AzVmss cmdlet implementation |
| src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs | Implemented parameter in config command and set property in VMSS object creation |
| src/Compute/Compute/Generated/Models/PSVirtualMachineScaleSet.cs | Added HighSpeedInterconnectPlacement property to the PowerShell model object |
| src/Compute/Compute/ChangeLog.md | Added changelog entry documenting the new parameter addition |
| src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1 | Implemented comprehensive test function covering parameter usage across different scenarios |
| src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.cs | Registered new test method for execution |
| [Parameter( | ||
| Mandatory = false, | ||
| ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "Specifies the high speed interconnect placement for the virtual machine scale set.")] | ||
| [PSArgumentCompleter("None", "Trunk")] | ||
| public string HighSpeedInterconnectPlacement { get; set; } |
There was a problem hiding this comment.
The HighSpeedInterconnectPlacement parameter is declared but not implemented in either the BuildPatchObject or BuildPutObject methods. You need to add logic similar to other parameters to actually set this property on the VirtualMachineScaleSet or VirtualMachineScaleSetUpdate objects.
For BuildPatchObject (used when VirtualMachineScaleSet is null), add:
if (this.IsParameterBound(c => c.HighSpeedInterconnectPlacement))
{
if (this.VirtualMachineScaleSetUpdate == null)
{
this.VirtualMachineScaleSetUpdate = new VirtualMachineScaleSetUpdate();
}
this.VirtualMachineScaleSetUpdate.HighSpeedInterconnectPlacement = this.HighSpeedInterconnectPlacement;
}
For BuildPutObject (used when VirtualMachineScaleSet is provided), add:
if (this.IsParameterBound(c => c.HighSpeedInterconnectPlacement))
{
this.VirtualMachineScaleSet.HighSpeedInterconnectPlacement = this.HighSpeedInterconnectPlacement;
}
| .SYNOPSIS | ||
| Test creating a VMSS with HighSpeedInterconnectPlacement set | ||
| #> | ||
| function Test-VirtualMachineScaleSetHighSpeedInterconnectPlacement |
There was a problem hiding this comment.
There is trailing whitespace at the end of this line after the function name. Please remove it.
| function Test-VirtualMachineScaleSetHighSpeedInterconnectPlacement | |
| function Test-VirtualMachineScaleSetHighSpeedInterconnectPlacement |
| # Setup | ||
| $rgname = Get-ComputeTestResourceName; | ||
| $loc = "westus2"; | ||
|
|
There was a problem hiding this comment.
There is trailing whitespace at the end of this line. Please remove it.
| $domainNameLabel1 = "d1" + $rgname; | ||
| $subnetName = 'subnet' + $rgname; | ||
| $vnetName = 'vnet' + $rgname; | ||
|
|
There was a problem hiding this comment.
There is trailing whitespace at the end of this line. Please remove it.
1 participant
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.