Skip to content

Conversation

@jairmyree
Copy link
Member

This pull request upgrades the vertx-codegen and vertx-core dependencies from version 4.5.17 to 4.5.23 across multiple modules to ensure consistency and benefit from the latest fixes and improvements. The changes update both direct dependencies and banned dependency rules, and document the updates in the changelog.

Dependency Upgrades:

  • Upgraded vertx-codegen from 4.5.17 to 4.5.23 in the following modules:
    • common/perf-test-core/pom.xml [1] [2]
    • sdk/core/azure-core-http-vertx/pom.xml
    • sdk/template/azure-template-stress/pom.xml
  • Upgraded vertx-core from 4.5.17 to 4.5.23 in sdk/core/azure-core-http-vertx/pom.xml

Banned Dependency Rules:

  • Updated banned dependency rules to reflect the new versions for both vertx-codegen and vertx-core:
    • common/perf-test-core/pom.xml
    • sdk/core/azure-core-http-vertx/pom.xml
    • sdk/template/azure-template-stress/pom.xml

Version Tracking:

  • Updated eng/versioning/external_dependencies.txt to track the new versions of vertx-codegen and vertx-core

Documentation:

  • Added a changelog entry in sdk/core/azure-core-http-vertx/CHANGELOG.md to document the dependency upgrades

Copilot AI review requested due to automatic review settings January 7, 2026 16:47
@github-actions github-actions bot added Azure.Core azure-core common common module used by all azure SDKs (e.g. client, Mgmt) EngSys This issue is impacting the engineering system. labels Jan 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades Vert.x dependencies (vertx-codegen and vertx-core) from version 4.5.17 to 4.5.23 across the repository to incorporate the latest fixes and improvements.

Key Changes:

  • Updated vertx-codegen and vertx-core versions in all affected POM files
  • Synchronized banned dependency rules to match the new versions
  • Documented the upgrade in the changelog

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/template/azure-template-stress/pom.xml Updated vertx-codegen dependency and banned dependency rule to version 4.5.23
sdk/core/azure-core-http-vertx/pom.xml Updated both vertx-codegen and vertx-core dependencies and their banned dependency rules to version 4.5.23
sdk/core/azure-core-http-vertx/CHANGELOG.md Added dependency upgrade entries under the unreleased version section
eng/versioning/external_dependencies.txt Updated the tracked versions for both Vert.x dependencies to 4.5.23
common/perf-test-core/pom.xml Updated vertx-codegen dependency and banned dependency rule to version 4.5.23

The changes are consistent across all files, with all references to version 4.5.17 successfully updated to 4.5.23. The changelog entry follows the established format and is properly placed in the "Unreleased" section under "Other Changes > Dependency Updates". No issues were identified with this PR.

@alzimmermsft
Copy link
Member

/check-enforcer override

@alzimmermsft
Copy link
Member

@microsoft-github-policy-service rerun

@alzimmermsft alzimmermsft merged commit 5508f56 into Azure:main Jan 8, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core azure-core common common module used by all azure SDKs (e.g. client, Mgmt) EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants