-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[NetAppFiles] Bump ANF to 2025-09-01 #53954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the Azure NetApp Files SDK from API version 2025-07-01-preview to 2025-09-01 (GA). The main changes include updating the API version across all generated files, modifying test files to disable preview-only features, and updating sample code examples to reference the new stable API version paths.
Key Changes:
- API version updated from
2025-07-01-previewto2025-09-01across all generated code - ANF Bucket tests completely commented out (feature appears to be preview-only)
- ListQuotaReport test commented out pending GA availability
- Sample files updated with new example definition paths from preview to stable
Reviewed Changes
Copilot reviewed 7 out of 293 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/netapp/Azure.ResourceManager.NetApp/src/autorest.md | Updated API version tag and spec commit reference for 2025-09-01 GA |
| sdk/netapp/Azure.ResourceManager.NetApp/tests/ResourceTests/ANFBucketTests.cs | Entire test file commented out - Bucket feature appears preview-only |
| sdk/netapp/Azure.ResourceManager.NetApp/tests/ResourceTests/VolumeTests.cs | ListQuotaReport test commented out with TODO for GA enablement |
| sdk/netapp/Azure.ResourceManager.NetApp/tests/ResourceTests/NetAppAccountTests.cs | Re-enabled GetAllNetAppAccountsBySubscription test, removed location override |
| sdk/netapp/Azure.ResourceManager.NetApp/tests/Generated/Samples/*.cs | Updated example definition paths from preview to stable, fixed subscription IDs |
| sdk/netapp/Azure.ResourceManager.NetApp/src/Generated/RestOperations/*.cs | API version updated to 2025-09-01, added pagination support for several operations |
| sdk/netapp/Azure.ResourceManager.NetApp/src/Generated/*Resource.cs | Updated API version in documentation comments |
| sdk/netapp/Azure.ResourceManager.NetApp/src/Generated/NetAppBucketResource.Serialization.cs | File deleted (Bucket feature not in GA) |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
| @@ -1374,24 +1306,21 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer | |||
| public override string ToString() { throw null; } | |||
| } | |||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | |||
| public readonly partial struct ExternalReplicationSetupStatus : System.IEquatable<Azure.ResourceManager.NetApp.Models.ExternalReplicationSetupStatus> | |||
| public readonly partial struct Exclude : System.IEquatable<Azure.ResourceManager.NetApp.Models.Exclude> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single-word names are not permitted. Please rename this enum to a more descriptive name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
Hey @audunn , please update the changelog.md and .csproj files to reflect the stable version and include the expected release date. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run net pullrequest |
|
No pipelines are associated with this pull request. |
|
/azp run net - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Release Plan Details
Spec pull request: [NetApp] fix things that should be in preview azure-rest-api-specs#38806
Spec API version: 2025-09-01