Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 27, 2025

multiapi is deprecated, making multiapi_combiner obsolete.

Changes

  • Deleted packaging_tools/multiapi_combiner.py (697 lines)
  • Deleted packaging_tools/templates/multiapi_combiner/ (9 jinja2 templates)
  • Removed multiapi_combiner console script entry from pyproject.toml

Total: 908 deletions across 11 files. No remaining references in codebase.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • pypi.org
    • Triggering command: python -m pip install --upgrade pip build (dns block)
    • Triggering command: /tmp/build-env-7kol1oqr/bin/python /home/REDACTED/work/azure-sdk-for-python/azure-sdk-for-python/.venv/lib/python3.9/site-packages/pip/__pip-REDACTED__.py --python /tmp/build-env-7kol1oqr/bin/python install --use-pep517 --no-warn-script-location --no-compile -r /tmp/build-reqs-4zfceink.txt (dns block)
    • Triggering command: /home/REDACTED/work/azure-sdk-for-python/azure-sdk-for-python/.venv/bin/python /home/REDACTED/work/azure-sdk-for-python/azure-sdk-for-python/.venv/lib/python3.9/site-packages/pip/__pip-REDACTED__.py install --ignore-installed --no-user --prefix /tmp/pip-build-env-z3m9cxh7/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i REDACTED -- setuptools>=42 wheel (dns block)
  • scanning-api.github.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>remove multiapi_combiner</issue_title>
<issue_description>multiapi is deprecated so we don't need multiapi_combiner at all.
TASK:
REMOVE all logic / files related with multiapi_combiner.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove all logic and files related to multiapi_combiner Remove multiapi_combiner Oct 27, 2025
Copilot finished work on behalf of msyyc October 27, 2025 07:27
Copilot AI requested a review from msyyc October 27, 2025 07:27
msyyc
msyyc previously approved these changes Oct 27, 2025
@msyyc msyyc marked this pull request as ready for review October 27, 2025 07:42
Copilot AI review requested due to automatic review settings October 27, 2025 07:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all code related to the deprecated multiapi_combiner tool, which is no longer needed since multiapi functionality has been deprecated. The changes clean up the codebase by removing the obsolete tooling without affecting any current functionality.

Key Changes

  • Removed the multiapi_combiner console script entry point from pyproject.toml
  • Deleted the entire multiapi_combiner.py implementation file (697 lines)
  • Deleted all associated Jinja2 templates used for code generation (9 template files)

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/tools/azure-sdk-tools/pyproject.toml Removed the multiapi_combiner console script entry point
eng/tools/azure-sdk-tools/packaging_tools/multiapi_combiner.py Deleted the entire multiapi_combiner implementation (697 lines)
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/validation.py.jinja2 Deleted validation decorator template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operations_init.py.jinja2 Deleted operations init template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operation_groups.py.jinja2 Deleted operation groups template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operation_group.py.jinja2 Deleted operation group template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operation.py.jinja2 Deleted operation template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/models_init.py.jinja2 Deleted models init template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/models.py.jinja2 Deleted models template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/enums.py.jinja2 Deleted enums template
eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/client.py.jinja2 Deleted client template

ChenxiJiang333
ChenxiJiang333 previously approved these changes Oct 27, 2025
@msyyc
Copy link
Member

msyyc commented Oct 27, 2025

/check-enforcer override

@msyyc
Copy link
Member

msyyc commented Oct 27, 2025

@scbedd Please help review this PR, thanks!

@msyyc msyyc enabled auto-merge (squash) October 27, 2025 07:45
scbedd
scbedd previously approved these changes Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Hi @copilot. We've noticed that new changes have been pushed to this pull request. Because it is set to automatically merge, we've reset the approvals to allow the opportunity to review the updates.

@github-actions github-actions bot dismissed stale reviews from msyyc, ChenxiJiang333, and scbedd November 7, 2025 18:28

Hi @msyyc. We've noticed that new changes have been pushed to this pull request. Because it is set to automatically merge, we've reset the approvals to allow the opportunity to review the updates.

@msyyc msyyc disabled auto-merge November 11, 2025 03:55
@msyyc msyyc merged commit c108629 into main Nov 11, 2025
20 checks passed
@msyyc msyyc deleted the copilot/remove-multiapi-combiner branch November 11, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove multiapi_combiner

5 participants