-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Remove multiapi_combiner #43642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multiapi_combiner #43642
Conversation
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all code related to the deprecated multiapi_combiner tool, which is no longer needed since multiapi functionality has been deprecated. The changes clean up the codebase by removing the obsolete tooling without affecting any current functionality.
Key Changes
- Removed the
multiapi_combinerconsole script entry point frompyproject.toml - Deleted the entire
multiapi_combiner.pyimplementation file (697 lines) - Deleted all associated Jinja2 templates used for code generation (9 template files)
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/tools/azure-sdk-tools/pyproject.toml | Removed the multiapi_combiner console script entry point |
| eng/tools/azure-sdk-tools/packaging_tools/multiapi_combiner.py | Deleted the entire multiapi_combiner implementation (697 lines) |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/validation.py.jinja2 | Deleted validation decorator template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operations_init.py.jinja2 | Deleted operations init template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operation_groups.py.jinja2 | Deleted operation groups template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operation_group.py.jinja2 | Deleted operation group template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/operation.py.jinja2 | Deleted operation template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/models_init.py.jinja2 | Deleted models init template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/models.py.jinja2 | Deleted models template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/enums.py.jinja2 | Deleted enums template |
| eng/tools/azure-sdk-tools/packaging_tools/templates/multiapi_combiner/client.py.jinja2 | Deleted client template |
|
/check-enforcer override |
|
@scbedd Please help review this PR, thanks! |
|
Hi @copilot. We've noticed that new changes have been pushed to this pull request. Because it is set to automatically merge, we've reset the approvals to allow the opportunity to review the updates. |
Hi @msyyc. We've noticed that new changes have been pushed to this pull request. Because it is set to automatically merge, we've reset the approvals to allow the opportunity to review the updates.
multiapiis deprecated, makingmultiapi_combinerobsolete.Changes
packaging_tools/multiapi_combiner.py(697 lines)packaging_tools/templates/multiapi_combiner/(9 jinja2 templates)multiapi_combinerconsole script entry frompyproject.tomlTotal: 908 deletions across 11 files. No remaining references in codebase.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
pypi.orgpython -m pip install --upgrade pip build(dns block)/tmp/build-env-7kol1oqr/bin/python /home/REDACTED/work/azure-sdk-for-python/azure-sdk-for-python/.venv/lib/python3.9/site-packages/pip/__pip-REDACTED__.py --python /tmp/build-env-7kol1oqr/bin/python install --use-pep517 --no-warn-script-location --no-compile -r /tmp/build-reqs-4zfceink.txt(dns block)/home/REDACTED/work/azure-sdk-for-python/azure-sdk-for-python/.venv/bin/python /home/REDACTED/work/azure-sdk-for-python/azure-sdk-for-python/.venv/lib/python3.9/site-packages/pip/__pip-REDACTED__.py install --ignore-installed --no-user --prefix /tmp/pip-build-env-z3m9cxh7/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i REDACTED -- setuptools>=42 wheel(dns block)scanning-api.github.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
multiapi_combiner#43641✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.