Sync eng/common directory with azure-sdk-tools for PR 12569 #43650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools to update the spell-checking infrastructure. The changes upgrade cspell from version 6.12.0 to 9.2.1 and refactor how files are passed to the spell checker.
Key changes:
- Upgrades cspell dependency from ^6.12.0 to ^9.2.1 and removes bundled dictionaries
- Refactors Invoke-Cspell.ps1 to accept files via stdin using pipeline input instead of glob patterns
- Updates parameter name from ScanGlobs to FileList in check-spelling-in-changed-files.ps1
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Bumps version to 1.0.0 and upgrades cspell to 9.2.1 |
| eng/common/spelling/Invoke-Cspell.ps1 | Refactors to use stdin for file input with begin/process/end blocks |
| eng/common/scripts/check-spelling-in-changed-files.ps1 | Updates parameter name from ScanGlobs to FileList |
azure-sdk
force-pushed
the
sync-eng/common-djurek/cspell-upgrade-12569
branch
from
dea458c to
eccbff1
Compare
azure-sdk
force-pushed
the
sync-eng/common-djurek/cspell-upgrade-12569
branch
from
eccbff1 to
8512598
Compare
danieljurek
approved these changes
Oct 30, 2025
JennyPng
pushed a commit
to JennyPng/azure-sdk-for-python
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12569 See eng/common workflow