Sync eng/common directory with azure-sdk-tools for PR 12569 #3264
+1,188
−2,254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools, updating the spelling check infrastructure to use cspell version 9.2.1 and refactoring how files are passed to the spell checker.
Key Changes:
- Upgrades cspell from version 6.12.0 to 9.2.1 and removes several bundled dictionary dependencies
- Refactors
Invoke-Cspell.ps1to accept files via stdin using aFileListparameter instead of glob patterns - Updates the caller script to use the new
FileListparameter name
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Updates cspell version to 9.2.1 and removes bundled dictionary dependencies |
| eng/common/spelling/Invoke-Cspell.ps1 | Refactors script to use stdin file list approach with begin/process/end blocks instead of glob-based configuration manipulation |
| eng/common/scripts/check-spelling-in-changed-files.ps1 | Updates parameter name from ScanGlobs to FileList to match refactored spelling script |
azure-sdk
force-pushed
the
sync-eng/common-djurek/cspell-upgrade-12569
branch
from
5de3df9 to
618435d
Compare
azure-sdk
force-pushed
the
sync-eng/common-djurek/cspell-upgrade-12569
branch
from
618435d to
ead295c
Compare
danieljurek
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12569 See eng/common workflow