Ignore blanks in XML parsing - allowing use of azurite emulator #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This PR will be left as is for future reference of using azurite emulator. Thanks! |
Member
|
@XiaoningLiu Can you take a look and comment on this? |
Member
|
Will add test case to validate. |
Member
|
Azurite V3 doesn't have space returned in XML response body. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this gem along with the azurite emulator (I don't run windows so this is the best one I have found) - fetching the cors configuration caused an error once cors configuration was present.
This was due to xml nodes just containing whitespace (\n character).
This PR simply sets the 'No Blanks' parser option in nokogiri.
I struggled to do any tests for this - the serialization tests seem to stub out internal methods which seemed a bit strange, which meant I could not put a new test in there without changing things around that area.
I tried integration tests, but I could not seem to configure it to use the azurite emulator.
However, the code is working in a real environment with azurite