Skip to content

Fix bug where 'in this call' text is incorrectly wrapped inside h2 tag #6010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix bug where 'in this call' text is incorrectly wrapped inside h2 tag #6010

wants to merge 13 commits into from
+12 −3

Conversation

@carocao-msft
Copy link
Contributor

@carocao-msft carocao-msft commented Nov 18, 2025

What

Fix bug where 'in this call' text is incorrectly wrapped inside h2 tag

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/4322330

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@carocao-msft carocao-msft requested review from a team as code owners November 18, 2025 00:32
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vcgcwughip.chromatic.com/

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58563 / 95087
61.58%		 58563 / 95087
61.58%		 1180 / 2709
43.55%		 3375 / 5774
58.45%
Current 58616 / 95087
61.64%		 58616 / 95087
61.64%		 1180 / 2709
43.55%		 3388 / 5787
58.54%
Diff 53 / 0
0.06%		 53 / 0
0.06%		 0 / 0
0%		 13 / 13
0.09%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29744 / 47381
62.77%		 29744 / 47381
62.77%		 810 / 1491
54.32%		 2428 / 3860
62.9%
Current 29744 / 47381
62.77%		 29744 / 47381
62.77%		 810 / 1491
54.32%		 2415 / 3853
62.67%
Diff 0 / 0
0%		 0 / 0
0%		 0 / 0
0%		 -13 / -7
-0.23%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-psglkwkkhy.chromatic.com/

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@carocao-msft carocao-msft added the update_snapshots Set this label to request automated update of UI snapshots label Nov 18, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Nov 18, 2025
@github-actions
Update packages/react-composites CallWithChatComposite browser test s…
fdf0c41 
…napshots
@github-actions
Update packages/react-composites ChatComposite browser test snapshots
e15536d
@github-actions
Merge branch 'carocao/HTMLTags' of https://github.com/Azure/communica…
d264700 
…tion-ui-library into carocao/HTMLTags
@github-actions
Update packages/react-composites CallWithChatComposite browser test s…
2938650 
…napshots
@github-actions
Merge branch 'carocao/HTMLTags' of https://github.com/Azure/communica…
2901925 
…tion-ui-library into carocao/HTMLTags
@github-actions
Update embed html bundle snapshots
c58a60d
@github-actions
Merge branch 'carocao/HTMLTags' of https://github.com/Azure/communica…
853c4d8 
…tion-ui-library into carocao/HTMLTags
@github-actions
Update packages/react-composites CallComposite browser test snapshots
3af21bc
@github-actions
Merge branch 'carocao/HTMLTags' of https://github.com/Azure/communica…
7186d84 
…tion-ui-library into carocao/HTMLTags
@github-actions
Update packages/react-composites CallComposite browser test snapshots
62e3cca
@github-actions
Merge branch 'carocao/HTMLTags' of https://github.com/Azure/communica…
35e2f3a 
…tion-ui-library into carocao/HTMLTags
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6767346 6767417 ⚠️ increased 71
580.bundle.js 12407925 12407925 ➖ unchanged 0

Total change: +71 B ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1793888 1793959 ⚠️ increased 71
398.bundle.js 375829 375829 ➖ unchanged 0
450.bundle.js 4454 4454 ➖ unchanged 0
82.bundle.js 28161 28161 ➖ unchanged 0
91.bundle.js 4102 4102 ➖ unchanged 0

Total change: +71 B ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 7758001 7758072 ⚠️ increased 71
450.bundle.js 4470 4470 ➖ unchanged 0
580.bundle.js 12407938 12407938 ➖ unchanged 0
727.bundle.js 372564 372564 ➖ unchanged 0
82.bundle.js 28177 28177 ➖ unchanged 0
91.bundle.js 4118 4118 ➖ unchanged 0

Total change: +71 B ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ymzmyodzlv.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AliRafiee AliRafiee Awaiting requested review from AliRafiee AliRafiee is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@juancamilor juancamilor Awaiting requested review from juancamilor juancamilor is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

At least 2 approving reviews are required to merge this pull request.

Assignees

@mgamis-msft mgamis-msft

@dmceachernmsft dmceachernmsft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carocao-msft @mgamis-msft @dmceachernmsft