WIP: Add Entra (AAD) authentication support #237
Conversation
stuartpa
force-pushed
the
stuartpa/aad-support
branch
2 times, most recently
from
af0cfd5 to
51ac5db
Compare
stuartpa
force-pushed
the
stuartpa/aad-support
branch
from
51ac5db to
3447fc1
Compare
| <PackageReference Include="Microsoft.Azure.SqlDatabase.ElasticScale.Client" Version="2.3.0" /> | ||
| <PackageReference Include="System.Configuration.ConfigurationManager" Version="5.0.0" /> | ||
| <PackageReference Include="EntityFramework" Version="6.4.4" /> | ||
| <PackageReference Include="System.Data.SqlClient" Version="4.8.5" /> |
There was a problem hiding this comment.
I see System.Data.SqlClient referenced here, but throughout the code I see Microsoft.Data.SqlClient. Is that correct?
Furthermore, I see Release 2.4.0 still is referencing Microsoft.Data.SqlClient 3.0.0 which is not the latest package which is 5.1.2. I believe the higher version package for Microsoft.Data.SqlClient will include a higher version of Azure.Identity.
There was a problem hiding this comment.
@tps-pcaldwell are you looking to use EF (Classic). The EF (Classic) sample hasn't been updated, because there has been no demand for it to be updated. Are you looking to use EF (Classic), or are you looking to use EF Core?
There was a problem hiding this comment.
Yes, I'm looking to use EF Core. In addition, the sample code is using the nuget reference, so it is still reference 2.3.0 instead of a project reference. I would recommend updating the nuget reference to 2.4.0 or removing the EF sample code which would be a shame.
There was a problem hiding this comment.
Yeah, I don't think we can update the EF Classic sample to 2.4 (which is .Net Core). We'll need to add another sample alongside the EF Classic sample for EF Core, which would use 2.4.
Are you interested in an EF Core sample using 2.4?
No description provided.