Do not retry non-GET requests by default #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="DeepInfra" |
|
this really bit me in the butt and got fetch-event-source spending a lot of LLM tokens as it was repeating POST requests all the time, and it would solve the pain for people on #36 for the most part if the maintainers could merge this, it would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason I started using this library is to do SSE events that require
POST. As you can imagine, those have state and shouldn't be reset by the client without a good reason.The default behavior (if no
onerrorandopenWhenHidden) are specified is to reset on close and on tab switch... So this PR modifies the default behavior for non GET requests, to get some sane behavior out-of-the-box.