Conversation
xinWeiWei24
reviewed
Jan 13, 2026
## Summary Updates the `image-pull-n10` pipeline to use the `image-pull` topology with registry scraping enabled, allowing collection of ACR metadata in test results. ## Changes - Changed topology from `cri-resource-consume` to `image-pull` - Added `scrape_registry: True` to enable ACR metadata collection - Added `registry_endpoint: acrtelescope.azurecr.io` to use ACR in same subscription (required for registry scraping) - Added `containerd_scrape_interval: 15s` parameter ## Test Results Pipeline link: [#20260112.5 • Add registry_endpoint for same-subscription ACR scraping](https://dev.azure.com/akstelescope/telescope/_build/results?buildId=48793&view=results)
xgugeng
commented
Jan 13, 2026
xgugeng
requested review from
anson627,
sumanthreddy29 and
wonderyl
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces ACR (Azure Container Registry) authentication control for image-pull scenarios by adding an anonymous_pull parameter that configures whether anonymous pull is enabled or disabled for ACR, and handles the corresponding AKS cluster authentication setup.
Changes:
- Adds new authentication script that dynamically enables/disables ACR anonymous pull based on the
anonymous_pullparameter - Integrates ACR authentication step into the image-pull validation workflow
- Corrects the default registry endpoint domain from
akscritelescope.azure.iotoakscritelescope.azurecr.io
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
steps/cloud/azure/authenticate-acr.yml |
New script that configures ACR anonymous pull settings and attaches ACR to AKS when authentication is needed |
steps/topology/image-pull/validate-resources.yml |
Adds conditional ACR authentication step for Azure cloud deployments |
modules/python/clusterloader2/cri/config/config.yaml |
Fixes registry endpoint domain to use correct azurecr.io format |
vittoriasalim
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an
anonymous_pullparameter in the pipeline configuration to control whether anonymous pull is used for ACR image pulls, and updates the ACR and AKS cluster settings accordingly.Latest pipeline run is here.