Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a typo in the Ray benchmark configuration file. The parameter name measurmentInterval (missing an 'e') has been corrected to measurementInterval in the SchedulingThroughput measurement configuration.
Changes:
- Corrected spelling of configuration parameter from
measurmentIntervaltomeasurementInterval
9990db5 to
4fb03a3
Compare
2958090 to
22c8425
Compare
vittoriasalim
previously approved these changes
Jan 14, 2026
7241279 to
e2f56fb
Compare
e2f56fb to
80f8f6c
Compare
alyssa1303
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Ray job controller configuration and templates to improve parameterization and flexibility, especially for image and resource specifications. The main changes include making image and GPU resource values configurable via template variables, fixing a typo in a configuration key, and improving the way configuration paths are resolved in the Python code.
Template and Configuration Improvements:
job_template.yamlto use template variables for the container image ({{.Image}}) and GPU resource requests/limits ({{.JobGPU}}) forray-submitter,ray-head, andray-workercontainers, allowing dynamic substitution during job creation. [1] [2] [3]objectTemplatePathinconfig.yamlto use a template variable ({{$job_template_path}}), making the job template path configurable.Bug Fixes and Path Handling:
config.yaml: correctedmeasurmentIntervaltomeasurementInterval.install_ray_dependenciesmethod injob_controller.pyto use the instance variableself.cl2_config_dirwhen resolving the Ray config directory, improving flexibility for different environments.