Skip to content

fix ray benchmark#1016

Merged
anson627 merged 7 commits intomainfrom
fix-ray-benchmark
Jan 14, 2026
Merged

fix ray benchmark#1016
anson627 merged 7 commits intomainfrom
fix-ray-benchmark

Conversation

@anson627
Copy link
Collaborator

@anson627 anson627 commented Jan 14, 2026

This pull request updates the Ray job controller configuration and templates to improve parameterization and flexibility, especially for image and resource specifications. The main changes include making image and GPU resource values configurable via template variables, fixing a typo in a configuration key, and improving the way configuration paths are resolved in the Python code.

Template and Configuration Improvements:

  • Updated job_template.yaml to use template variables for the container image ({{.Image}}) and GPU resource requests/limits ({{.JobGPU}}) for ray-submitter, ray-head, and ray-worker containers, allowing dynamic substitution during job creation. [1] [2] [3]
  • Changed objectTemplatePath in config.yaml to use a template variable ({{$job_template_path}}), making the job template path configurable.

Bug Fixes and Path Handling:

  • Fixed a typo in config.yaml: corrected measurmentInterval to measurementInterval.
  • Updated the install_ray_dependencies method in job_controller.py to use the instance variable self.cl2_config_dir when resolving the Ray config directory, improving flexibility for different environments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a typo in the Ray benchmark configuration file. The parameter name measurmentInterval (missing an 'e') has been corrected to measurementInterval in the SchedulingThroughput measurement configuration.

Changes:

  • Corrected spelling of configuration parameter from measurmentInterval to measurementInterval

vittoriasalim
vittoriasalim previously approved these changes Jan 14, 2026
@anson627 anson627 merged commit 28ddfdd into main Jan 14, 2026
3 checks passed
@anson627 anson627 deleted the fix-ray-benchmark branch January 14, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants