Merged
Conversation
mijpeterson
force-pushed
the
remediate-test-failures
branch
from
30ddfac to
d88e48e
Compare
mijpeterson
commented
Jun 12, 2025
Contributor
Author
mijpeterson
left a comment
mijpeterson
left a comment
There was a problem hiding this comment.
Some helpful notes for people who might be reviewing.
Haard30
approved these changes
Jun 12, 2025
aschlesener
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I made this PR, I realized that the test workflows were failing due to auth errors even though we previously had spent substantial effort to have them dynamically pull in access tokens to be able to connect to the Office feed.
It seems that with the ongoing security hardening, however, that having these actions performed via GitHub workflows is becoming less and less practical. On top of all of that, our ADO instance is moving to an entirely different tenant altogether that will prevent GitHub from even being able to generate tokens via FIC.
With all the writing on the wall, I decided to move our automated workflows over to Azure pipelines since this seems to be the only way to future proof ourselves against further hardening.