Add AIDL interface for device registration service., Fixes AB#3127905#2926
Add AIDL interface for device registration service., Fixes AB#3127905#2926
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Pull request overview
Introduces a new bound-service IPC surface for device registration and refines the bound-service client extension API to be less externally accessible.
Changes:
- Added
IDeviceRegistrationService.aidldefining a bound-service contract for device registration protocol execution. - Added
DeviceRegistrationServiceClientto bind to the broker’s device registration service and delegate the protocol call via AIDL. - Tightened
BoundServiceClient/MicrosoftAuthClientextension point visibility (performOperationInternal,getInterfaceFromIBinder) toprotected.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| common/src/main/java/com/microsoft/identity/common/internal/broker/ipc/DeviceRegistrationServiceClient.kt | New bound-service client for device registration IPC delegation. |
| common/src/main/java/com/microsoft/identity/common/internal/broker/MicrosoftAuthClient.java | Restricts internal bound-service extension methods to protected. |
| common/src/main/java/com/microsoft/identity/common/internal/broker/BoundServiceClient.java | Makes subclass extension points protected abstract for encapsulation. |
| common/src/main/aidl/com/microsoft/identity/client/IDeviceRegistrationService.aidl | New AIDL contract for device registration protocol invocation. |
...in/java/com/microsoft/identity/common/internal/broker/ipc/DeviceRegistrationServiceClient.kt
Outdated
Show resolved
Hide resolved
...in/java/com/microsoft/identity/common/internal/broker/ipc/DeviceRegistrationServiceClient.kt
Outdated
Show resolved
Hide resolved
...in/java/com/microsoft/identity/common/internal/broker/ipc/DeviceRegistrationServiceClient.kt
Show resolved
Hide resolved
common/src/main/aidl/com/microsoft/identity/client/IDeviceRegistrationService.aidl
Outdated
Show resolved
Hide resolved
common/src/main/aidl/com/microsoft/identity/client/IDeviceRegistrationService.aidl
Outdated
Show resolved
Hide resolved
|
❌ Invalid work item number: AB#3127905 Click here to learn more. |
|
✅ Work item link check complete. Description contains link AB#3127905 to an Azure Boards work item. |
| * | ||
| * @param context the application context used to bind to the service. | ||
| */ | ||
| class DeviceRegistrationServiceClient(context: Context) : |
There was a problem hiding this comment.
should this be in the broker repo?
There was a problem hiding this comment.
We are planning to expose the DR API to OneAuth so we need this interface here, if I move it to broker it will be back in common.
This pull request introduces a new IPC client for device registration and refines access control for service client methods. The most significant changes are the addition of the
DeviceRegistrationServiceClient, the definition of its AIDL interface, and the adjustment of method visibility in service client classes for better encapsulation.Device Registration IPC Integration
IDeviceRegistrationService.aidlto define the contract for device registration operations between the broker and client.DeviceRegistrationServiceClient.kt, a Kotlin class that binds to the device registration service and executes device registration protocol operations via IPC.Service Client API Refinement
performOperationInternalandgetInterfaceFromIBindermethods inBoundServiceClient.javaandMicrosoftAuthClient.javafromabstract/publictoprotected abstract/protected, restricting their accessibility to subclasses only. [1] [2] [3]AB#3127905
Related PR: https://github.com/identity-authnz-teams/ad-accounts-for-android/pull/81