Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Common library’s OpenTelemetry enums to support tracing and attributing device registration IPC flows, enabling more granular diagnostics for device registration across IPC strategies.
Changes:
- Added
DeviceRegistrationIpcto theSpanNameenum. - Added new device registration IPC-related keys to the
AttributeNameenum (content_provider_status,bound_service_status,legacy_am_status,device_registration_protocol_name).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java | Adds a dedicated span name for device registration IPC operations. |
| common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java | Adds new attribute keys intended to describe device registration IPC strategy outcomes/protocol. |
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java
Show resolved
Hide resolved
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java
Outdated
Show resolved
Hide resolved
|
✅ Work item link check complete. Description contains link AB#3534948 to an Azure Boards work item. |
rpdome
approved these changes
Mar 9, 2026
mohitc1
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new telemetry support for device registration IPC strategies by introducing several new attributes and a span name. These changes will allow us to track and diagnose device registration flows more effectively in distributed tracing.
Telemetry attribute additions:
AttributeNameenum values for device registration IPC strategies:content_provider_status,bound_service_status,legacy_am_status, anddevice_registration_protocol_name, enabling more granular telemetry on device registration flows.Span name additions:
DeviceRegistrationIpcto theSpanNameenum, allowing tracing of device registration IPC operations as distinct spans.AB#3534948