Skip to content

Add device registration IPC attributes to AttributeName enum and update SpanName enum, Fixes AB#3534948#3007

Merged
p3dr0rv merged 3 commits intodevfrom
pedroro/update-otel-for-dr-api
Mar 16, 2026
Merged

Add device registration IPC attributes to AttributeName enum and update SpanName enum, Fixes AB#3534948#3007
p3dr0rv merged 3 commits intodevfrom
pedroro/update-otel-for-dr-api

Conversation

@p3dr0rv
Copy link
Contributor

@p3dr0rv p3dr0rv commented Mar 6, 2026

This pull request adds new telemetry support for device registration IPC strategies by introducing several new attributes and a span name. These changes will allow us to track and diagnose device registration flows more effectively in distributed tracing.

Telemetry attribute additions:

  • Added new AttributeName enum values for device registration IPC strategies: content_provider_status, bound_service_status, legacy_am_status, and device_registration_protocol_name, enabling more granular telemetry on device registration flows.

Span name additions:

  • Added DeviceRegistrationIpc to the SpanName enum, allowing tracing of device registration IPC operations as distinct spans.
    AB#3534948

@p3dr0rv p3dr0rv requested a review from a team as a code owner March 6, 2026 01:55
Copilot AI review requested due to automatic review settings March 6, 2026 01:55
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Common library’s OpenTelemetry enums to support tracing and attributing device registration IPC flows, enabling more granular diagnostics for device registration across IPC strategies.

Changes:

  • Added DeviceRegistrationIpc to the SpanName enum.
  • Added new device registration IPC-related keys to the AttributeName enum (content_provider_status, bound_service_status, legacy_am_status, device_registration_protocol_name).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/SpanName.java Adds a dedicated span name for device registration IPC operations.
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/AttributeName.java Adds new attribute keys intended to describe device registration IPC strategy outcomes/protocol.

@p3dr0rv p3dr0rv added the No-Changelog This Pull-Request has no associated changelog entry. label Mar 6, 2026
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

✅ Work item link check complete. Description contains link AB#3534948 to an Azure Boards work item.

@github-actions github-actions bot changed the title Add device registration IPC attributes to AttributeName enum and update SpanName enum Add device registration IPC attributes to AttributeName enum and update SpanName enum, Fixes AB#3534948 Mar 6, 2026
Copy link
Contributor

@mohitc1 mohitc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@p3dr0rv p3dr0rv merged commit 7d482a9 into dev Mar 16, 2026
27 checks passed
@p3dr0rv p3dr0rv deleted the pedroro/update-otel-for-dr-api branch March 16, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-Changelog This Pull-Request has no associated changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants