Skip to content

Add HTTP retry flight definitions to CommonFlight, Fixes AB#3536277#3008

Draft
Copilot wants to merge 2 commits intodevfrom
copilot/add-http-retry-flight-definitions
Draft

Add HTTP retry flight definitions to CommonFlight, Fixes AB#3536277#3008
Copilot wants to merge 2 commits intodevfrom
copilot/add-http-retry-flight-definitions

Conversation

Copy link
Contributor

Copilot AI commented Mar 7, 2026

Adds 6 new flight-gated entries to CommonFlight to enable runtime control of HTTP retry behavior (max attempts, delays, backoff, jitter, Retry-After header respect).

Changes

  • common4j/.../flighting/CommonFlight.java — 6 new enum constants appended:
Constant Flight Key Default
HTTP_RETRY_MAX_ATTEMPTS "HttpRetryMaxAttempts" 3
HTTP_RETRY_INITIAL_DELAY_MS "HttpRetryInitialDelayMs" 1000
HTTP_RETRY_EXTENSION_FACTOR "HttpRetryExtensionFactor" 2
HTTP_RETRY_JITTER_FACTOR "HttpRetryJitterFactor" 0.5
HTTP_RETRY_RESPECT_RETRY_AFTER "HttpRetryRespectRetryAfter" true
HTTP_RETRY_MAX_TOTAL_DELAY_MS "HttpRetryMaxTotalDelayMs" 60000

All entries follow the existing CommonFlight(String key, Object defaultValue) constructor pattern. No existing entries were modified. This is a foundational PBI — the retry logic consuming these flights is not included here.

Original prompt

Add HTTP retry flight definitions to CommonFlight

Fixes AB#3536277

Repo

AzureAD/microsoft-authentication-library-common-for-android Module: common4j

Description

Add 6 new flight entries to the CommonFlight enum in common4j for flight-gated HTTP retry configuration. This is the foundation PBI.

Flight entries to add

Enum Constant Flight Name Type Default
HTTP_RETRY_MAX_ATTEMPTS "HttpRetryMaxAttempts" int 3
HTTP_RETRY_INITIAL_DELAY_MS "HttpRetryInitialDelayMs" int 1000
HTTP_RETRY_EXTENSION_FACTOR "HttpRetryExtensionFactor" int 2
HTTP_RETRY_JITTER_FACTOR "HttpRetryJitterFactor" double 0.5
HTTP_RETRY_RESPECT_RETRY_AFTER "HttpRetryRespectRetryAfter" boolean true
HTTP_RETRY_MAX_TOTAL_DELAY_MS "HttpRetryMaxTotalDelayMs" int 60000

Files to Modify

  • common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java

Acceptance Criteria

  • 6 new flight entries added with correct names and defaults
  • Follow existing enum constructor pattern
  • No existing entries modified
  • Compiles cleanly

Dependencies

None

Follow .github/copilot-instructions.md strictly


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-actions
Copy link

github-actions bot commented Mar 7, 2026

✅ Work item link check complete. Description contains link AB#3536277 to an Azure Boards work item.

@github-actions github-actions bot changed the title [WIP] Add HTTP retry flight definitions to CommonFlight [WIP] Add HTTP retry flight definitions to CommonFlight, Fixes AB#3536277 Mar 7, 2026
Co-authored-by: shahzaibj <37125644+shahzaibj@users.noreply.github.com>
Copilot AI changed the title [WIP] Add HTTP retry flight definitions to CommonFlight, Fixes AB#3536277 Add HTTP retry flight definitions to CommonFlight Mar 7, 2026
@github-actions github-actions bot changed the title Add HTTP retry flight definitions to CommonFlight Add HTTP retry flight definitions to CommonFlight, Fixes AB#3536277 Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants