Skip to content

Conversation

@reynoldskr
Copy link
Contributor

@reynoldskr reynoldskr commented Oct 23, 2025

Changes proposed in this request
Before .NET 10, RuntimeInformation.OSDescription called uname on *nix systems to populate itself. Now it uses a nicer way using the .NET runtime target information, that means that field no longer contains Darwin, so IsMac always returned false. This simply lets that method check for macOs as well.

Testing
I couldn't find any unit tests for this class.

Performance impact
None

@reynoldskr reynoldskr requested a review from a team as a code owner October 23, 2025 02:34
@bgavrilMS bgavrilMS requested a review from fengga October 23, 2025 10:14
@bgavrilMS
Copy link
Member

@fengga - smth for you to review

@reynoldskr
Copy link
Contributor Author

reynoldskr commented Oct 29, 2025

Hey @bgavrilMS / @fengga , any chance of a review here 🙂 ?

@reynoldskr
Copy link
Contributor Author

This is still broken BTW, and net10 is GA now

@jrr
Copy link

jrr commented Nov 25, 2025

This is a real thing blocking me from updating a project to .NET 10.

For what it's worth, here are some values from my machine:

Log.Debug("Platform: {OsVersionPlatform}", Environment.OSVersion.Platform);
Log.Debug("OSDescription: {OsDescription}", RuntimeInformation.OSDescription);
Log.Debug("Is OSX: {IsOsPlatform}", RuntimeInformation.IsOSPlatform(OSPlatform.OSX));
[22:28:40 DBG] Platform: Unix
[22:28:40 DBG] OSDescription: macOS 26.1.0
[22:28:40 DBG] Is OSX: True

(so I think you could either look for the string "macOS" (as in this PR) or call IsOSPlatform)

For comparison, here are the values from .NET 9:

[23:26:02 DBG] Platform: Unix
[23:26:02 DBG] OSDescription: Darwin 25.1.0 Darwin Kernel Version 25.1.0: Mon Oct 20 19:32:41 PDT 2025; root:xnu-12377.41.6~2/RELEASE_ARM64_T6000
[23:26:02 DBG] Is OSX: True

Update: the problem isn't specific to MacOS 26! It also happens with .NET 10 on earlier OS versions:

Microsoft.Data.SqlClient.SqlException (0x80131904): macOS 15.6.1
 ---> System.PlatformNotSupportedException: macOS 15.6.1

Copy link
Contributor

@fengga fengga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@DharshanBJ DharshanBJ enabled auto-merge (squash) December 4, 2025 04:46
@bgavrilMS bgavrilMS disabled auto-merge December 4, 2025 16:44
@cricketthomas
Copy link

Would really love for this to get merged and released! It would solve so many issues! Thanks

@bgavrilMS bgavrilMS force-pushed the dev/kreynolds/fix_net10_macos26 branch from 8ed8c0b to 87d1834 Compare December 6, 2025 11:26
@bgavrilMS bgavrilMS merged commit 4dd269e into AzureAD:main Dec 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants