Skip to content

Conversation

@HanBnrd
Copy link
Contributor

@HanBnrd HanBnrd commented Jun 6, 2025

TODOs:

  • Add a test snirf file with both measurementList and measurementLists
  • Write a test for the new CONFLICTING_FIELDS_PRESENT error

Ping @sreekanthkura7

@sstucker, we were wondering if introducing a new error code (after the OK code) will be okay with the rest of the validation?

@sreekanthkura7
Copy link
Contributor

@HanBnrd, There were a few issues with the code we wrote earlier, which I’ve now fixed. I created three SNIRF files—one with just measurementList, one with just measurementLists, and one with both—to test the updated code. We can go through the changes and approve the PR in tomorrow’s meeting.

@sreekanthkura7 sreekanthkura7 marked this pull request as ready for review July 4, 2025 12:27
@sreekanthkura7 sreekanthkura7 merged commit 6275042 into BUNPC:main Aug 7, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants