Skip to content

Conversation

@VicenteCartas
Copy link
Contributor

This PR adds:

  • If a non-node-based particle system is selected: view in NPE.
  • If a node-based particle system is selected: edit in NPE.
  • In node-based systems, edits from NPE are persisted into the system, so they will be kept when NPE is closed.

PG to test: #0K3AQ2#3751
image

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

Snapshot stored with reference name:
refs/pull/17628/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17628/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17628/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17628/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17628/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17628/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17628/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17628/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17628/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17628/merge/?snapshot=refs/pull/17628/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17628/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

@deltakosh deltakosh marked this pull request as draft January 8, 2026 18:11
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17628/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17628/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17628/merge/?snapshot=refs/pull/17628/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2026

import { Texture } from "core/Materials/Textures/texture";
import { ShowInspector } from "../../src";

import "node-particle-editor/legacy/legacy"; // Ensure node particle editor legacy code is imported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. I will change it later to not go through the legacy path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants