This repository was archived by the owner on Aug 24, 2019. It is now read-only.
Fix coverage with mixed objc swift project#31
Open
Branlute wants to merge 2 commits intoBackelite:masterfrom
Open
Fix coverage with mixed objc swift project#31Branlute wants to merge 2 commits intoBackelite:masterfrom
Branlute wants to merge 2 commits intoBackelite:masterfrom
Conversation
|
Hi @Branlute, I dont think it is necessary to rename the coverage report even when using both languages. I think the coverage report is global for the project and not language dependent (but I'm not sure). Do you have a special case that lead you to do that ? Regards, |
Author
|
Hi @zippy1978 , You are right, the coverage report is global, but if SonarQube has both Objective-C and Swift plugins installed, both plugins will try to upload coverage to SonarQube, and SonarQube will only accept one report. So you will have an error. With this fix, the Objective-c plugin will not upload the coverage generated by swift's script "run-sonar.sh" and vice versa. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #50 on sonar-swift
Same Pull Request is open on sonar-swift Idean/sonar-swift#88
Change pattern for coverage.xml for avoid conflicts when upload to SonarQube coverage with both plugins Objective-c and swift.